ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #31: ARIA-30-SQL-based-storage-implementati...
Date Wed, 07 Dec 2016 12:00:59 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/31#discussion_r91277752
  
    --- Diff: tests/storage/__init__.py ---
    @@ -33,10 +35,30 @@ def teardown_method(self):
             rmtree(self.path, ignore_errors=True)
     
     
    -def get_sqlite_api_kwargs():
    -    engine = create_engine('sqlite:///:memory:',
    -                           connect_args={'check_same_thread': False},
    -                           poolclass=StaticPool)
    -    session = orm.sessionmaker(bind=engine)()
    +def get_sqlite_api_kwargs(base_dir=None, filename='memory'):
    +    """
    +    Create sql params. works in in-memory and in filesystem mode.
    +    If base_dir is passed, the mode will be filesystem mode. while the default mode is
in-memory.
    +    :param str base_dir: The base dir for the filesystem memory file.
    +    :param str filename: the file name - defaults to 'memory'.
    --- End diff --
    
    ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message