ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #31: ARIA-30-SQL-based-storage-implementati...
Date Sun, 04 Dec 2016 16:12:56 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/31#discussion_r90780099
  
    --- Diff: tests/storage/test_model_storage.py ---
    @@ -13,150 +13,91 @@
     # See the License for the specific language governing permissions and
     # limitations under the License.
     
    +import tempfile
    +import shutil
    +
     import pytest
     
    +
     from aria.storage import (
    -    Storage,
         ModelStorage,
         models,
    +    exceptions,
    +    sql_mapi,
     )
    -from aria.storage import structures
    -from aria.storage.exceptions import StorageError
    -from aria.storage.structures import Model, Field, PointerField
     from aria import application_model_storage
    +from tests.storage import get_sqlite_api_params
    +
    +temp_dir = tempfile.mkdtemp()
    +
     
    -from . import InMemoryModelDriver
    +@pytest.fixture
    +def storage():
    +    return ModelStorage(sql_mapi.SQLAlchemyModelAPI, api_params=get_sqlite_api_params())
     
     
    -def test_storage_base():
    -    driver = InMemoryModelDriver()
    -    storage = Storage(driver)
    +@pytest.fixture(autouse=True)
    --- End diff --
    
    remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message