ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #12: ARIA-3 Create an API for creating work...
Date Mon, 07 Nov 2016 14:39:14 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/12#discussion_r86780724
  
    --- Diff: tests/workflows/api/test_task_graph.py ---
    @@ -298,8 +491,139 @@ def test_remove_dependency_nonexistent_dependency(self, graph):
             with pytest.raises(task_graph.TaskNotInGraphError):
                 graph.remove_dependency(task, task_not_in_graph)
     
    +    def test_remove_dependency_empty_dependent(self, graph):
    +        task = MockTask()
    +        graph.add_tasks(task)
    +        # expecting remove_dependency result to be False - no dependency has been created
    +        assert graph.remove_dependency([], task) is False
    --- End diff --
    
    need to be consistent - either all True or all False


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message