ariatosca-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #7: pylint aria.storage
Date Thu, 20 Oct 2016 14:32:10 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/7#discussion_r84292148
  
    --- Diff: aria/storage/models.py ---
    @@ -251,13 +278,21 @@ class Node(Model):
         max_number_of_instances = Field(type=int)
     
         def relationships_by_target(self, target_id):
    +        """
    +        Retreives all of the relationship by target.
    +        :param target_id: the node id of the target  of the relationship
    +        :return:
    --- End diff --
    
    return statement's empty; since you're yielding it probably requires a different syntax.
    i know google's syntax has a ":yields:" keyword, but since we haven't settled on a format
yet i dont know if it should be used or simply have the return removed..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message