Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32360200D1A for ; Sun, 3 Sep 2017 15:00:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 311D7164474; Sun, 3 Sep 2017 13:00:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 442FE164473 for ; Sun, 3 Sep 2017 15:00:16 +0200 (CEST) Received: (qmail 41415 invoked by uid 500); 3 Sep 2017 13:00:15 -0000 Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ariatosca.incubator.apache.org Delivered-To: mailing list commits@ariatosca.incubator.apache.org Received: (qmail 41397 invoked by uid 99); 3 Sep 2017 13:00:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Sep 2017 13:00:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0BC13F5589; Sun, 3 Sep 2017 13:00:12 +0000 (UTC) From: ran-z To: commits@ariatosca.apache.org Reply-To: commits@ariatosca.apache.org References: In-Reply-To: Subject: [GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp... Content-Type: text/plain Message-Id: <20170903130014.0BC13F5589@git1-us-west.apache.org> Date: Sun, 3 Sep 2017 13:00:12 +0000 (UTC) archived-at: Sun, 03 Sep 2017 13:00:17 -0000 Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r136714399 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/data_types.py --- @@ -159,10 +159,6 @@ def get_data_type(context, presentation, field_name, allow_none=False): else: return str - # Make sure not derived from self - if type_name == presentation._name: --- End diff -- what is this about? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---