Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: AviaE <git@git.apache.org>
To: commits@ariatosca.apache.org
Reply-To: commits@ariatosca.apache.org
References: <git-pr-189-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-189-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase
Content-Type: text/plain
Message-Id: <20170802181125.8C2D7DFA3C@git1-us-west.apache.org>
Date: Wed,  2 Aug 2017 18:11:25 +0000 (UTC)
archived-at: Wed, 02 Aug 2017 18:11:27 -0000

Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/189#discussion_r130842710
  
    --- Diff: aria/parser/consumption/modeling.py ---
    @@ -74,7 +75,7 @@ def dump(self):
                 raw = self.context.modeling.template_as_raw
                 self.context.write(json_dumps(raw, indent=indent))
             else:
    -            self.context.modeling.template.dump()
    +            self.topology.dump(self.context.modeling.template)
     
     
     class Types(Consumer):
    --- End diff --
    
    If this class is no longer needed to show ('dump') the types, consider deleting it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---