ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AviaE <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase
Date Wed, 09 Aug 2017 10:05:56 GMT
Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132136296
  
    --- Diff: aria/orchestrator/topology/template_handler.py ---
    @@ -584,13 +588,20 @@ def instantiate(self, instance_cls):
     
             return operation
     
    -    def validate(self):
    +    def validate(self, **kwargs):
             self._validate(self._model.inputs,
    -                       self._model.configurations)
    +                       self._model.configurations,
    +                       **kwargs)
    +
    +
    +class PluginSpecification(common.TemplateHandlerBase):
    --- End diff --
    
    Consider inheriting from `HandlerBase`, since `PluginSpecification` isn't exactly a template.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message