ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access
Date Mon, 07 Aug 2017 16:25:19 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131700894
  
    --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py ---
    @@ -150,17 +146,29 @@ def __exit__(self, *args, **kwargs):
             self.close()
     
     
    -def _process_ctx_request(ctx, args): # pylint: disable=too-many-branches,too-many-statements
    -    current = ctx
    -    index = 0
    +class ProcessingError(RuntimeError):
    +    pass
    +
     
    +class ParsingError(ProcessingError):
    +    pass
    +
    +
    +def _parse_request(ctx, request):
    +    request = json.loads(request)
    +    args = request['args']
    +    return _parse_arguments(ctx, args)
    +
    +
    +def _parse_arguments(obj, args):
    +    # Modifying?
         try:
             # TODO: should there be a way to escape "=" in case it is needed as real argument?
    -        equals_index = args.index('=')
    +        equals_index = args.index('=') # raises ValueError if not found
    --- End diff --
    
    It looks more awkward, but +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message