ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access
Date Sun, 06 Aug 2017 08:13:45 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131536369
  
    --- Diff: tests/orchestrator/execution_plugin/test_ctx_proxy_server.py ---
    @@ -55,61 +55,32 @@ def test_dict_prop_access_set(self, server, ctx):
             assert ctx.node.properties['prop3'][2]['value'] == 'new_value_2'
             assert ctx.node.properties['prop4']['some']['new']['path'] == 'some_new_value'
     
    +    def test_dict_prop_access_set_with_list_index(self, server, ctx):
    --- End diff --
    
    :+1: 
    consider also adding test for something like `node.some_attr.some_method(*some_args).return_attr
= some_value`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message