ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AviaE <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase
Date Tue, 01 Aug 2017 22:30:05 GMT
Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/189#discussion_r130586353
  
    --- Diff: aria/core.py ---
    @@ -122,6 +118,8 @@ def delete_service(self, service_id, force=False):
         def _parse_service_template(service_template_path):
             context = consumption.ConsumptionContext()
             context.presentation.location = UriLocation(service_template_path)
    +        # TODO: this is the last place which uses the consumer chains (since read is
a proper Parser
    --- End diff --
    
    this comment does not explain that you didn't change this section because it was not in
the scope of refactoring instantiation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message