Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: tliron <git@git.apache.org>
To: commits@ariatosca.apache.org
Reply-To: commits@ariatosca.apache.org
References: <git-pr-143-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-143-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...
Content-Type: text/plain
Message-Id: <20170710075120.7727CE383A@git1-us-west.apache.org>
Date: Mon, 10 Jul 2017 07:51:20 +0000 (UTC)
archived-at: Mon, 10 Jul 2017 07:51:22 -0000

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/143#discussion_r126353998
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py ---
    @@ -162,6 +164,30 @@ def convert_capability_from_definition_to_assignment(context, presentation, cont
         return CapabilityAssignment(name=presentation._name, raw=raw, container=container)
     
     
    +def merge_capability_definition(context, presentation, capability_definition,
    +                                from_capability_definition):
    --- End diff --
    
    Because I prefer it to fit with the style of the rest of code right now, to keep it consistent. I would like to change it, but everything together and give it some more thought.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---