Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: ran-z <git@git.apache.org>
To: commits@ariatosca.apache.org
Reply-To: commits@ariatosca.apache.org
References: <git-pr-145-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-145-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #145: ARIA-260 Send interface inputs as arg...
Content-Type: text/plain
Message-Id: <20170705083921.51FEFDF9C3@git1-us-west.apache.org>
Date: Wed,  5 Jul 2017 08:39:21 +0000 (UTC)
archived-at: Wed, 05 Jul 2017 08:39:23 -0000

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/145#discussion_r125584770
  
    --- Diff: tests/instantiation/test_configuration.py ---
    @@ -0,0 +1,175 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +import pytest
    +
    +from tests.parser.service_templates import consume_literal
    +
    +
    +TEMPLATE = """
    +tosca_definitions_version: tosca_simple_yaml_1_0
    +
    +interface_types:
    --- End diff --
    
    This seems like it covers the basic case, but there are many other scenarios which we might want to test as well, e.g.:
    1) interface type input overridden by an operation input defined under a node type and not in the interface
    2) interface type input overridden by an operation input in an interface type inheriting from this interface type
    3) interface type input overridden by an operation input in an interface type overridden by an operation input under a node type overridden by an operation input under a node template
    ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---