ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <>
Subject [GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase
Date Mon, 31 Jul 2017 11:47:26 GMT
Github user mxmrlv commented on a diff in the pull request:
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/ ---
    @@ -497,8 +497,8 @@ def get(name, default=None):
     def create_workflow_operation_template_model(context, service_template, policy):
    -    model = OperationTemplate(name=policy._name,
    -                              service_template=service_template)
    +    model = OperationTemplate(name=policy._name)
    +    service_template.workflow_templates[] = model
    --- End diff --
    since we use backpopulates, these fields are populated upon commit, we get a weird (temporary)
behavior where in previous code `service_template.workflows` is a dict which has `None` as
key for the value of model.
    This needs to be addressed throughout the code.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message