ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access
Date Sun, 30 Jul 2017 17:14:18 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247176
  
    --- Diff: aria/orchestrator/workflows/api/task.py ---
    @@ -140,13 +140,18 @@ def __init__(self,
             self.arguments = modeling_utils.merge_parameter_values(arguments,
                                                                    operation.arguments,
                                                                    model_cls=models.Argument)
    -        if getattr(self.actor, 'outbound_relationships', None) is not None:
    +
    +        actor = self.actor
    +        if hasattr(actor, '_wrapped'):
    --- End diff --
    
    Because you often get instrumented/wrapped models here, and they would fail the `isinstance`
check. (With duck typing check they succeed, but I thought duck typing was bad.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message