ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <>
Subject [GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access
Date Sun, 30 Jul 2017 12:27:47 GMT
Github user mxmrlv commented on a diff in the pull request:
    --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/ ---
    @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs):
    -def _process_ctx_request(ctx, args):
    +def _process_ctx_request(ctx, args): # pylint: disable=too-many-branches,too-many-statements
         current = ctx
    -    num_args = len(args)
         index = 0
    --- End diff --
    I think we need to think this semantics through, in the current situation we support assignment
of value, given the last argument is value. Inserting the `=` might imply you can insert `=`
at any phase.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message