ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AviaE <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #187: ARIA-313 Fix handling the `required` ...
Date Thu, 27 Jul 2017 17:48:20 GMT
Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/187#discussion_r129910938
  
    --- Diff: aria/orchestrator/workflows/api/task.py ---
    @@ -137,6 +137,11 @@ def __init__(self,
             operation = self.actor.interfaces[self.interface_name].operations[self.operation_name]
             self.plugin = operation.plugin
             self.function = operation.function
    +
    +        modeling_utils.validate_required_inputs_are_supplied(
    +            declared_inputs=operation.inputs,
    +            supplied_inputs=operation.arguments)
    --- End diff --
    
    After consulting with @tliron and reviewing the TOSCA spec, I came to the conclusion that
the validation of the `required` field of inputs that belong to operations and interfaces
(as opposed to topology template and workflow inputs) should be done in the parsing stage.
    This reasoning follows the TOSCA spirit, where anything that is declared in the type and
is required, must be assigned in the corresponding template.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message