ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Date Wed, 12 Jul 2017 08:47:43 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/185#discussion_r126896663
  
    --- Diff: tests/orchestrator/workflows/core/test_events.py ---
    @@ -105,6 +106,39 @@ def test_node_state_changes_as_a_result_of_standard_lifecycle_delete_shorthand_n
             ctx, interface_name=SHORTHAND_NAME, op_name='delete', executor=executor)
         _assert_node_state_changed_as_a_result_of_standard_lifecycle_operation(node, 'delete')
     
    +def test_node_state_changes_as_a_result_of_standard_lifecycle_create_typequalified_name(ctx,
    --- End diff --
    
    Basically this tests module tests the events and the state changes associated with them.
Since the shorthand_name and the type_qualified_name are handled the same in that regard,
maybe it'd be better to write tests for `get_type_by_full_or_shorthand_or_typequalified_name`
and `convert_shorthand_typequalified_to_full_type_name`, and place these under `tests/parser/test_tosca_simple_v1_0/presentation/types.py`,
and move the `test_tosca_simple_v1_0.py` module to be under `tests/parser/test_tosca_simple_v1_0/end2end.py`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message