ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...
Date Wed, 05 Jul 2017 20:55:41 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125755316
  
    --- Diff: aria/modeling/service_template.py ---
    @@ -690,19 +666,104 @@ def dump(self):
                 console.puts(context.style.meta(self.description))
             with context.style.indent:
                 console.puts('Type: {0}'.format(context.style.type(self.type.name)))
    -            console.puts('Instances: {0:d} ({1:d}{2})'.format(
    -                self.default_instances,
    -                self.min_instances,
    -                ' to {0:d}'.format(self.max_instances)
    -                if self.max_instances is not None
    -                else ' or more'))
                 utils.dump_dict_values(self.properties, 'Properties')
                 utils.dump_dict_values(self.attributes, 'Attributes')
                 utils.dump_interfaces(self.interface_templates)
                 utils.dump_dict_values(self.artifact_templates, 'Artifact templates')
                 utils.dump_dict_values(self.capability_templates, 'Capability templates')
                 utils.dump_list_values(self.requirement_templates, 'Requirement templates')
     
    +    @property
    +    def next_index(self):
    --- End diff --
    
    Actually, this was intentional -- I thought it could be useful for outside callers. But
no problem changed this and also `_next_name` similarly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message