ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...
Date Wed, 05 Jul 2017 20:49:39 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125753807
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py ---
    @@ -52,12 +52,13 @@ def get_inherited_capability_definitions(context, presentation, for_presentation
         Allows overriding all aspects of parent capability properties except data type.
         """
     
    +    if for_presentation is None:
    +        for_presentation = presentation
    +
         # Get capability definitions from parent
         parent = presentation._get_parent(context)
    -    capability_definitions = get_inherited_capability_definitions(context, parent,
    -                                                                  for_presentation=presentation)
\
    -                                                                  if parent is not None
\
    -                                                                  else OrderedDict()
    +    capability_definitions = get_inherited_capability_definitions(
    +        context, parent, for_presentation) if parent is not None else OrderedDict()
     
         # Add/merge our capability definitions
         our_capability_definitions = presentation.capabilities
    --- End diff --
    
    I tend to agree. :( This is some very tricky code that has gone through a lot of changes.
I do want to fix this (there are a bunch of related files in this module) but I don't think
this PR is the right place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message