ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #145: ARIA-260 Send interface inputs as arg...
Date Wed, 05 Jul 2017 20:45:38 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/145#discussion_r125752870
  
    --- Diff: tests/instantiation/test_configuration.py ---
    @@ -0,0 +1,175 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +import pytest
    +
    +from tests.parser.service_templates import consume_literal
    +
    +
    +TEMPLATE = """
    +tosca_definitions_version: tosca_simple_yaml_1_0
    +
    +interface_types:
    --- End diff --
    
    On second look, I disagree with your suggested test cases. The `instantiation` testing
is supposed to test instantiation, and what you're suggesting is parsing. Especially when
we introduce a real instantiation module soon, I think such tests would look very strange
here.
    
    We obviously need to test the things you mention, but they are part of parser testing,
a huge undertaking which we have yet to begin...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message