Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: mxmrlv <git@git.apache.org>
To: commits@ariatosca.apache.org
Reply-To: commits@ariatosca.apache.org
References: <git-pr-156-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-156-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #156: ARIA-278 remove core tasks
Content-Type: text/plain
Message-Id: <20170620121030.0C329DFA28@git1-us-west.apache.org>
Date: Tue, 20 Jun 2017 12:10:30 +0000 (UTC)
archived-at: Tue, 20 Jun 2017 12:10:31 -0000

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/156#discussion_r122956391
  
    --- Diff: aria/orchestrator/workflows/executor/base.py ---
    @@ -28,19 +28,20 @@ class BaseExecutor(logger.LoggerMixin):
         def _execute(self, task):
             raise NotImplementedError
     
    -    def execute(self, task):
    +    def execute(self, ctx):
             """
             Execute a task
             :param task: task to execute
             """
    -        if task.function:
    -            self._execute(task)
    -        else:
    -            # In this case the task is missing a function. This task still gets to an
    -            # executor, but since there is nothing to run, we by default simply skip the execution
    -            # itself.
    -            self._task_started(task)
    -            self._task_succeeded(task)
    +        with ctx.track_changes:
    --- End diff --
    
    reconsider


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---