Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: mxmrlv <git@git.apache.org>
To: commits@ariatosca.apache.org
Reply-To: commits@ariatosca.apache.org
References: <git-pr-141-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-141-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #141: ARIA-262 inconsistent node attributes...
Content-Type: text/plain
Message-Id: <20170604162438.D34C4DFB01@git1-us-west.apache.org>
Date: Sun,  4 Jun 2017 16:24:38 +0000 (UTC)
archived-at: Sun, 04 Jun 2017 16:24:40 -0000

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/141#discussion_r120014181
  
    --- Diff: aria/orchestrator/decorators.py ---
    @@ -68,11 +68,13 @@ def operation(func=None, toolbelt=False, suffix_template='', logging_handlers=No
     
         @wraps(func)
         def _wrapper(**func_kwargs):
    +        ctx = func_kwargs.pop('ctx')
             if toolbelt:
    -            operation_toolbelt = context.toolbelt(func_kwargs['ctx'])
    +            operation_toolbelt = context.toolbelt(ctx)
                 func_kwargs.setdefault('toolbelt', operation_toolbelt)
    -        validate_function_arguments(func, func_kwargs)
    -        return func(**func_kwargs)
    +        validate_function_arguments(func, ctx=ctx, **func_kwargs)
    --- End diff --
    
    instead of pop, use get, dont use **, later pop ctx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---