ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #166: ARIA-294 workflow tasks execution is ...
Date Wed, 28 Jun 2017 08:50:58 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/166#discussion_r124483622
  
    --- Diff: aria/modeling/orchestration.py ---
    @@ -397,13 +397,8 @@ def retry(message=None, retry_interval=None):
             raise TaskRetryException(message, retry_interval=retry_interval)
     
         @declared_attr
    -    def dependency_fk(self):
    -        return relationship.foreign_key('task', nullable=True)
    -
    -    @declared_attr
         def dependencies(cls):
    -        # symmetric relationship causes funky graphs
    -        return relationship.one_to_many_self(cls, 'dependency_fk')
    +        return relationship.many_to_many(cls, 'task', self=True)
    --- End diff --
    
    no need for other model if self=true


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message