ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxmrlv <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #163: introduced process grouping
Date Tue, 27 Jun 2017 13:20:07 GMT
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/163#discussion_r124256836
  
    --- Diff: aria/orchestrator/workflows/executor/process.py ---
    @@ -125,10 +140,16 @@ def _execute(self, ctx):
     
             env = self._construct_subprocess_env(task=ctx.task)
             # Asynchronously start the operation in a subprocess
    -        subprocess.Popen(
    -            '{0} {1} {2}'.format(sys.executable, __file__, arguments_json_path),
    +        proc = subprocess.Popen(
    +            [
    +                sys.executable,
    +                os.path.expanduser(os.path.expandvars(__file__)),
    +                os.path.expanduser(os.path.expandvars(arguments_json_path))
    +            ],
                 env=env,
    -            shell=True)
    +            preexec_fn=os.setsid)
    --- End diff --
    
    incompatible with windows


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message