ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AviaE <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #147: ARIA-275 Update nfv profile to csd04
Date Mon, 12 Jun 2017 18:27:59 GMT
Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/147#discussion_r121486606
  
    --- Diff: extensions/aria_extension_tosca/profiles/tosca-simple-nfv-1.0/nodes.yaml ---
    @@ -83,100 +86,37 @@ node_types:
               type: tosca.datatypes.network.PortInfo
             status: deprecated
         capabilities:
    -      # ARIA NOTE: I commented out the virtual_storage capability as tosca.capabilities.nfv.VirtualStorage
    -      # does not exist in csd04. csd04 even states:
    -      # "Editor Note: Need to create tosca.capabilities.nfv.VirtualStorage capability
type."
           virtual_compute:
    -        description: Describes virtual compute resources capabilities.
    +        description: >-
    +          Describes virtual compute resources capabilities.
             type: tosca.capabilities.nfv.VirtualCompute
           virtual_binding:
    -        description: Defines ability of VirtualBindable
    +        description: >-
    +          Defines ability of VirtualBindable.
             type: tosca.capabilities.nfv.VirtualBindable
    -
    -      # ARIA NOTE: the "monitoring_parameter" capability is already commented out in
the spec, and
    -      # is copied here verbatim from section [5.9.2.5 Definition].
    -      # However, in section [5.9.2.4 Capabilities], the type of this capability is
    -      # tosca.capabilities.nfv.Metric, and it also has a description.
    -      # In addition, the spec might be wrong here regarding the name of this capability,
since a
    -      # very similar capability exists in section [5.9.6 tosca.nodes.nfv.VnfVirtualLinkDesc]
and is
    -      # named "monitoring_parameters" (as opposed to "monitoring_parameter" in here)
    -
    -      #monitoring_parameter:
    -        # modeled as ad hoc (named) capabilities in VDU node template
    -        # for example:
    -        #capabilities:
    -        #  cpu_load: tosca.capabilities.nfv.Metric
    -        # memory_usage: tosca.capabilities.nfv.Metric
    -
    -      # ARIA NOTE: The capabilities 'host', 'endpoint', 'os', 'scalable', 'binding' are
only
    -      # described in section [5.9.2.5 Definition], but are not mentioned in section
    -      # [5.9.2.4 Capabilities] they are inherited from tosca.nodes.Compute.
    -
    -      host: #Editor note: FFS. How this capabilities should be used in NFV Profile
    -        type: tosca.capabilities.Container
    -        valid_source_types: [tosca.nodes.SoftwareComponent]
    -        occurrences: [ 0, UNBOUNDED ]
    -      endpoint:
    -      # ARIA NOTE: lacks type in contrast with the TOSCA spec, so I added one.
    -      # In addition, I commented out the 'occurrences' field since its value is not valid.
I'm
    -      # guessing it was just csd04's way of saying that this requirement is deprecated.
But I'm not
    -      # sure if this is the best way to do it.
    -        type: tosca.capabilities.Endpoint.Admin
    -      # occurrences: [ 0, 0 ]
    -      os:
    -      # ARIA NOTE: lacks type in contrast with the TOSCA spec, so I added one.
    -      # In addition I commented out the 'occurrences' field since its value is not valid.
I'm
    -      # guessing it was just csd04's way of saying that this requirement is deprecated.
But I'm not
    -      # sure if this is the best way to do it.
    -        type: tosca.capabilities.OperatingSystem
    -      # occurrences: [ 0, 0 ]
    -      scalable: #Editor note: FFS. How this capabilities should be used in NFV Profile
    -        type: tosca.capabilities.Scalable
    -      binding:
    -      # ARIA NOTE: lacks type in contrast with the TOSCA spec, so I added one.
    -        type: tosca.capabilities.network.Bindable
    -        occurrences: [ 0, UNBOUNDED ]
    -    requirements:
    -      # ARIA NOTE: I commented out the virtual_storage requirement as both
    -      # tosca.capabilities.nfv.VirtualStorage and tosca.relationships.nfv.VDU.AttachedTo
    -      # do not exist in csd04.
    -#     - virtual_storage:
    -#         capability: tosca.capabilities.nfv.VirtualStorage
    -#         relationship: tosca.relationships.nfv.VDU.AttachedTo
    -#         node: tosca.nodes.nfv.VDU.VirtualStorage
    -#         occurrences: [ 0, UNBOUNDED ]
    -      - local_storage: #For NFV Profile, this requirement is deprecated.
    -          # ARIA NOTE: I added 'capability', 'node' and 'relationship' fields to to this
requirement
    -          # to make it valid TOSCA, even though it is 'deprecated' according to csd04.
    -          # In Addition, I commented out the 'occurrences' field since its value is not
valid. I'm
    -          # guessing it was just csd04's way of saying that this requirement is deprecated.
But I'm
    -          # not sure if this is the best way to do it.
    -          capability: tosca.capabilities.Attachment
    -          node: tosca.nodes.BlockStorage
    -          relationship: tosca.relationships.AttachesTo
    -        # occurrences: [ 0,0 ]
    +      monitoring_parameter:
    +        # ARIA NOTE: commented out in 5.9.2.5
    +        description: >-
    +          Monitoring parameter, which can be tracked for a VNFC based on this VDU. Examples
include:
    +          memory-consumption, CPU-utilisation, bandwidth-consumption, VNFC downtime,
etc.        
    +        type: tosca.capabilities.nfv.Metric
    +    #requirements:
    +      # ARIA NOTE: virtual_storage is TBD
    +      
    +      # ARIA NOTE: csd04 attempts to deprecate the inherited local_storage requirement,
but this
    +      # is not possible in TOSCA
         artifacts:
    -    # ARIA NOTE: in csd04 the artifacts are described as a list, but in TOSCA they are
defined as a
    -    # map
           sw_image:
             description: >-
               Describes the software image which is directly loaded on the virtualization
container
               realizing this virtual storage.
             file: # ARIA NOTE: missing value even though it is required in TOSCA
    --- End diff --
    
    change to `file: ''`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message