ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #143: ARIA-254 Create of multiple nodes per...
Date Tue, 06 Jun 2017 19:20:12 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/143#discussion_r120455451
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/types.py ---
    @@ -13,7 +13,7 @@
     # See the License for the specific language governing permissions and
     # limitations under the License.
     
    -from aria.utils.collections import FrozenDict, FrozenList
    +from aria.utils.collections import (FrozenDict, FrozenList)
    --- End diff --
    
    I thought we agreed that that kind of style is a recommendation but not a requirement.
If we switch to that style here it would make a lot of the parser code extremely verbose and
frankly unreadable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message