ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AviaE <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #146: ARIA-199 Add "services outputs" CLI c...
Date Sun, 04 Jun 2017 13:31:58 GMT
Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/146#discussion_r120009903
  
    --- Diff: tests/mock/models.py ---
    @@ -96,6 +97,9 @@ def create_service_with_dependencies(include_execution=False,
         if include_input:
             input = create_parameter(name='input1', value='value1')
             service.inputs = {'input1': input}
    +    if include_output:
    --- End diff --
    
    Now, that ARIA-180 was merged, we have a dedicated `create_input` function.
    Similarly, please add a `create_output` function =)
    In addition, as in `services outputs` we also print the description of the output, so
it would be nice to add the description as a parameter to the `create_output` function, and
to check for the existence of that printed description in the console output (`logger output
string`).
    
    On another note, According to the TOSCA spec, inputs also have a description, and the
is not addressed in the current `create_input` and tests for `services outputs`. You have
me permission [:)] to fix it in the context of this commit, as it is very closely related
to it. If you prefer not to, it will be addressed in this JIRA: https://issues.apache.org/jira/browse/ARIA-192
("Fix output inconsistencies in CLI").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message