ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #145: ARIA-260 Send interface inputs as arg...
Date Sun, 04 Jun 2017 10:39:55 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/145#discussion_r120006635
  
    --- Diff: tests/end2end/test_nodecellar.py ---
    @@ -40,3 +40,21 @@ def _verify_deployed_service_in_storage(service_name, model_storage):
         assert service.name == service_name
         assert len(service.executions) == 0  # dry executions leave no traces
         assert len(service.nodes) == 10
    +    assert set(service.nodes['loadbalancer_host_1'].interfaces['Standard'].operations['create']
\
    --- End diff --
    
    While these additions are fine, I think this JIRA really calls for unit tests which will
check the various options for passing in arguments and verify everything overrides what it
should and only that.
    There are many such scenarios, and you don't want to test them all in e2e tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message