Mailing-List: contact commits-help@ariatosca.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ariatosca.incubator.apache.org
From: tliron <git@git.apache.org>
To: commits@ariatosca.apache.org
Reply-To: commits@ariatosca.apache.org
References: <git-pr-138-incubator-ariatosca@git.apache.org>
In-Reply-To: <git-pr-138-incubator-ariatosca@git.apache.org>
Subject: [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Content-Type: text/plain
Message-Id: <20170531190940.68316DFF66@git1-us-west.apache.org>
Date: Wed, 31 May 2017 19:09:40 +0000 (UTC)
archived-at: Wed, 31 May 2017 19:09:42 -0000

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119447056
  
    --- Diff: aria/modeling/utils.py ---
    @@ -51,74 +53,95 @@ def service_template(self):
             return self.container.service_template
     
     
    -def create_inputs(inputs, template_inputs):
    +def merge_parameter_values(parameter_values, declared_parameters, forbidden_names=None):
    --- End diff --
    
    The original code was superfluous and complex, doing unpacking and re-packing of values, and actually had a bug in one area of it. I think this code is much cleaner!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---