ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tliron <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Date Wed, 31 May 2017 19:04:58 GMT
Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445999
  
    --- Diff: aria/orchestrator/workflows/events_logging.py ---
    @@ -35,20 +35,20 @@ def _get_task_name(task):
     
     @events.start_task_signal.connect
     def _start_task_handler(task, **kwargs):
    -    # If the task has not implementation this is an empty task.
    -    if task.implementation:
    +    # If the task has no function this is an empty task.
    +    if task.function:
             suffix = 'started...'
             logger = task.context.logger.info
         else:
    -        suffix = 'has no implementation'
    +        suffix = 'has no function'
    --- End diff --
    
    Changing back to "implementation".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message