ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Date Wed, 31 May 2017 18:57:04 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119427199
  
    --- Diff: aria/orchestrator/workflow_runner.py ---
    @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution):
             active_executions = [e for e in self.service.executions if e.is_active()]
             if active_executions:
                 raise exceptions.ActiveExecutionsError(
    -                "Can't start execution; Service {0} has an active execution with id {1}"
    +                "Can't start execution; Service {0} has an active execution with ID {1}"
                     .format(self.service.name, active_executions[0].id))
     
    -    def _get_workflow_fn(self):
    +    @property
    +    def _workflow_fn(self):
    --- End diff --
    
    what's a `property` about this? it's a function with possible side effects, its private,
and it isn't really meant to be used repeatedly, so i think it actually stands better as a
function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message