ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Date Wed, 31 May 2017 18:57:04 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119428842
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py ---
    @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):
                 e, final = evaluate(e, final, container_holder)
                 if e is not None:
                     value.write(unicode(e))
    -        value = value.getvalue()
    +        value = value.getvalue() or u''
    --- End diff --
    
    why do the value we return here need to be unicode again?
    i understand the need to support unicode values which are set by the user, but why does
it matter whether the value returned in case there never was a value is unicode or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message