ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <>
Subject [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Date Wed, 31 May 2017 18:57:04 GMT
Github user ran-z commented on a diff in the pull request:
    --- Diff: aria/orchestrator/workflows/ ---
    @@ -35,20 +35,20 @@ def _get_task_name(task):
     def _start_task_handler(task, **kwargs):
    -    # If the task has not implementation this is an empty task.
    -    if task.implementation:
    +    # If the task has no function this is an empty task.
    +    if task.function:
             suffix = 'started...'
             logger =
    -        suffix = 'has no implementation'
    +        suffix = 'has no function'
    --- End diff --
    actually, in this specific instance, it should probably remain `implementation` - function
is an implementation (sorry for the confusing term in this context :D) detail, but in practice
what the message means is that the user didn't input (there i go with the terms again.. :D)
any implementation for the operation (AKA empty operation)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message