ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Date Wed, 31 May 2017 18:57:04 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119442939
  
    --- Diff: aria/modeling/utils.py ---
    @@ -52,84 +53,95 @@ def service_template(self):
             return self.container.service_template
     
     
    -def create_parameters(parameters, declared_parameters):
    +def merge_parameter_values(parameter_values, declared_parameters, forbidden_names=None):
    --- End diff --
    
    i thought we talked about the concept of validating "forbidden names" and we agreed it
should be done in the parser / instantiation phases instead. I don't see in what scenario
we'd like to inform the user of such validation errors only at this stage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message