ariatosca-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran-z <...@git.apache.org>
Subject [GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...
Date Tue, 23 May 2017 14:02:46 GMT
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/138#discussion_r117999899
  
    --- Diff: aria/modeling/exceptions.py ---
    @@ -22,9 +22,9 @@ class ModelingException(AriaException):
         """
     
     
    -class InputsException(ModelingException):
    +class ParameterException(ModelingException):
    --- End diff --
    
    I'm not sure I understand this change - It's true that the model object is `Parameter`
and not `Inputs` (although that too is supposedly under change by @AviaE ) - but the error
itself is not about the model type and doesn't have anything much to do with the models themselves
- it's about inputs, so why shouldn't the exception be named like so?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message