archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dtrebbien <...@git.apache.org>
Subject [GitHub] archiva pull request #30: SLF4J-related fixes
Date Sun, 30 Jul 2017 20:31:23 GMT
GitHub user dtrebbien opened a pull request:

    https://github.com/apache/archiva/pull/30

    SLF4J-related fixes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dtrebbien/archiva slf4j-related-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/archiva/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 0b15664f1c667c6bab69d44ffa6f5cf966ae38cf
Author: Daniel Trebbien <dtrebbien@gmail.com>
Date:   2017-07-30T20:26:05Z

    Utilize parameterized logging and remove toString() calls
    
    As suggested in the SLF4J FAQ:
    https://www.slf4j.org/faq.html#logging_performance
    .. parameterized logging can improve the efficiency of logger calls when
    logging at the specified level is disabled.
    
    In addition, per the FAQ: https://www.slf4j.org/faq.html#paramException
    since SLF4J 1.6.0 it is possible to use parameterized logging and also
    log an exception/throwable.
    
    toString() is called automatically:
    https://www.slf4j.org/faq.html#string_contents
    
    These changes were suggested by SLF4J Helper for NetBeans IDE:
    http://plugins.netbeans.org/plugin/72557/

commit da107994474d9fcb672501e3905cee6595ff0c6a
Author: Daniel Trebbien <dtrebbien@gmail.com>
Date:   2017-07-30T20:29:29Z

    Fix two incorrect SLF4J logger calls
    
    These issues were found by SLF4J Helper for NetBeans IDE:
    http://plugins.netbeans.org/plugin/72557/

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message