archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ecki <...@git.apache.org>
Subject [GitHub] archiva pull request: Remove Sonar Dead Store Issues.
Date Mon, 12 Oct 2015 22:57:46 GMT
Github user ecki commented on a diff in the pull request:

    https://github.com/apache/archiva/pull/18#discussion_r41810172
  
    --- Diff: archiva-modules/plugins/stage-repository-merge/src/main/java/org/apache/archiva/stagerepository/merge/Maven2RepositoryMerger.java
---
    @@ -194,9 +194,6 @@ private void createFolderStructure( String sourceRepoId, String targetRepoId,
Ar
             copyFile( sourceArtifactFile, targetArtifactFile );
     
             // pom file copying
    -        String fileName = artifactMetadata.getProject() + "-" + artifactMetadata.getVersion()
+ ".pom";
    -
    -        // pom file copying
             // TODO need to use path translator to get the pom file path
    --- End diff --
    
    The assign is not used and seems to have not side effect. The code is commented out a
bit lower ... should that dead code block be removed as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message