archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ecki <...@git.apache.org>
Subject [GitHub] archiva pull request: Remove Sonar Dead Store Issues.
Date Mon, 12 Oct 2015 22:56:57 GMT
Github user ecki commented on a diff in the pull request:

    https://github.com/apache/archiva/pull/18#discussion_r41810121
  
    --- Diff: archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/dependency/tree/maven2/Maven3DependencyTreeBuilder.java
---
    @@ -280,12 +280,8 @@ private RepositorySystemSession newRepositorySystemSession( RepositorySystem
sys
             DependencySelector depFilter = new AndDependencySelector( new ExclusionDependencySelector()
);
             session.setDependencySelector( depFilter );
     
    -        LocalRepository localRepo = new LocalRepository( localRepoDir );
             session.setLocalRepositoryManager(
    -            new SimpleLocalRepositoryManager( localRepoDir ) );// system.newLocalRepositoryManager(
localRepo ) );
    -
    -        //session.setTransferListener(  );
    -        //session.setRepositoryListener( n );
    +            new SimpleLocalRepositoryManager( localRepoDir ) );
    --- End diff --
    
    Other option is to remove `String msg` completely. Or should it be logged as INFO?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message