archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ecki <...@git.apache.org>
Subject [GitHub] archiva pull request: Remove Sonar Dead Store Issues.
Date Mon, 12 Oct 2015 22:56:18 GMT
Github user ecki commented on a diff in the pull request:

    https://github.com/apache/archiva/pull/18#discussion_r41810093
  
    --- Diff: archiva-modules/archiva-web/archiva-rest/archiva-rest-services/src/main/java/org/apache/archiva/rest/services/DefaultRepositoriesService.java
---
    @@ -423,7 +423,7 @@ public Boolean copyArtifact( ArtifactTransferRequest artifactTransferRequest
)
                 String timestamp = null;
     
                 File versionMetadataFile = new File( targetPath, MetadataTools.MAVEN_METADATA
);
    -            ArchivaRepositoryMetadata versionMetadata = getMetadata( versionMetadataFile
);
    +            /* unused */ getMetadata( versionMetadataFile );
    --- End diff --
    
    Probably can be removed as the metadata is not used. However since the method throws I
kept it. Can if this is used to verify that meta data exists it should be probably documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message