archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: svn commit: r1379434 - /archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-metadata-consumer/src/main/java/org/apache/archiva/consumers/metadata/ArchivaMetadataCreationConsumer.java
Date Fri, 31 Aug 2012 13:01:03 GMT
Hi,

2012/8/31  <skygo@apache.org>:
> Author: skygo
> Date: Fri Aug 31 12:55:59 2012
> New Revision: 1379434
>
> URL: http://svn.apache.org/viewvc?rev=1379434&view=rev
> Log:
> add repoId to log
>
> Modified:
>     archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-metadata-consumer/src/main/java/org/apache/archiva/consumers/metadata/ArchivaMetadataCreationConsumer.java
>
> Modified: archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-metadata-consumer/src/main/java/org/apache/archiva/consumers/metadata/ArchivaMetadataCreationConsumer.java
> URL: http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-metadata-consumer/src/main/java/org/apache/archiva/consumers/metadata/ArchivaMetadataCreationConsumer.java?rev=1379434&r1=1379433&r2=1379434&view=diff
> ==============================================================================
> --- archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-metadata-consumer/src/main/java/org/apache/archiva/consumers/metadata/ArchivaMetadataCreationConsumer.java
(original)
> +++ archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-metadata-consumer/src/main/java/org/apache/archiva/consumers/metadata/ArchivaMetadataCreationConsumer.java
Fri Aug 31 12:55:59 2012
> @@ -176,7 +176,7 @@ public class ArchivaMetadataCreationCons
>              }
>              catch ( RepositoryStorageMetadataNotFoundException e )
>              {
> -                log.warn( "Missing or invalid POM for artifact: " + path + "; creating
empty metadata" );
> +                log.warn( "Missing or invalid POM for artifact:" + path + " (" + repoId
+ "); creating empty metadata" );
For performance reason, It's better to use slf4j feature (see
http://www.slf4j.org/faq.html#logging_performance )
 log.warn( "Missing or invalid POM for artifact:" + path  ({});
creating empty metadata", repoId);
>
>                  versionMetadata = new ProjectVersionMetadata();
>                  versionMetadata.setId( projectVersion );
> @@ -185,7 +185,7 @@ public class ArchivaMetadataCreationCons
>              }
>              catch ( RepositoryStorageMetadataInvalidException e )
>              {
> -                log.warn( "Error occurred resolving POM for artifact: " + path + ";
message: " + e.getMessage() );
> +                log.warn( "Error occurred resolving POM for artifact:" + path + "("
+ repoId + "); message: " + e.getMessage() );
>              }
>
>              // read the metadata and update it if it is newer or doesn't exist
> @@ -202,12 +202,12 @@ public class ArchivaMetadataCreationCons
>          }
>          catch ( MetadataRepositoryException e )
>          {
> -            log.warn( "Error occurred persisting metadata for artifact: " + path + ";
message: " + e.getMessage(), e );
> +            log.warn( "Error occurred persisting metadata for artifact: " + path + "("
+ repoId + "); message: " + e.getMessage(), e );
>              repositorySession.revert();
>          }
>          catch ( RepositoryStorageRuntimeException e )
>          {
> -            log.warn( "Error occurred persisting metadata for artifact: " + path + ";
message: " + e.getMessage(), e );
> +            log.warn( "Error occurred persisting metadata for artifact: " + path + "("
+ repoId + "); message: " + e.getMessage(), e );
>              repositorySession.revert();
>          }
>          finally
>
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

Mime
View raw message