archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: [continuum] BUILD FAILURE: Archiva (trunk) - Apache Archiva - Default Maven 2 Build Definition
Date Fri, 20 May 2011 15:37:58 GMT
2011/5/20 Brett Porter <brett@apache.org>:
>
> On 20/05/2011, at 11:24 PM, Olivier Lamy wrote:
>
>> Hello,
>> Yup I'm aware of that.
>> The remove of plexus(-spring) in redback introduces some failures in Archiva.
>> I'm working on (it was quiet long with redback : I now imagine with
>> Archiva :-) ).
>
> It's also broken Continuum's build... might need some direction on how to fix that with
minimal effort.

Doh I will work again on Continuum :-)

>
>>
>> I will name spring bean with something like :
>>
>> * @plexus.component role="org.apache.maven.archiva.policies.PreDownloadPolicy"
>> * role-hint="cache-failures"
>> */
>> @Service("preDownloadPolicy#cache-failures")
>> public class CachedFailuresPolicy implements PreDownloadPolicy
>>
>> Will be more easy for various piece of codes which use lookupMap from plexus.
>>
>> Objections ?
>
> Sounds fine to me!

And I miss the famous default :-) :
sample :
/*
 * @plexus.component role="org.apache.maven.archiva.policies.PreDownloadPolicy"
 */
@Service("preDownloadPolicy#default")
public class CachedFailuresPolicy implements PreDownloadPolicy

Note I have added something which mimic the lookupMap with Spring
(here http://svn.codehaus.org/redback/components/trunk/spring-utils/src/main/java/org/codehaus/redback/components/springutils/ComponentContainer.java
)

BTW some failure I have is the lazy component loading which is not the
default behaviour with Spring (with units test annotated with
@RunWith( SpringJUnit4ClassRunner.class ) )

>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
>
>
>
>
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://www.linkedin.com/in/olamy

Mime
View raw message