archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deng Ching <och...@apache.org>
Subject Re: svn commit: r940163 - in /archiva/trunk/archiva-modules/archiva-web: archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/ archiva-webapp/src/main/java/org/apache/
Date Mon, 03 May 2010 06:51:37 GMT
On Mon, May 3, 2010 at 2:22 PM, Brett Porter <brett@apache.org> wrote:

> Hi Deng,
>
> On 02/05/2010, at 4:13 PM, oching@apache.org wrote:
>
> >
> >
> > -            // explicitly update only if metadata-updater consumer is
> not enabled!
> > -            if (
> !config.getRepositoryScanning().getKnownContentConsumers().contains(
> "metadata-updater" ) )
> > +            // explicitly update only if versionMetadata-updater
> consumer is not enabled!
> > +            if (
> !config.getRepositoryScanning().getKnownContentConsumers().contains(
> "versionMetadata-updater" ) )
>
> Looks like your search/replace went rogue :)
>

Oops, I didn't notice that :) Thanks for the catch!


>
> > +        String projectPath = targetPath.substring( 0,
> targetPath.lastIndexOf( File.separatorChar ) );
> > +        File projectMetadataFile = getMetadata( projectPath );
>
> I know that code was already there, but I think you could improve it's
> reliability with:
> File projectDir = new File( targetPath ).getParentFile();
> File projectMetadataFile = new File( projectDir, MAVEN_METADATA );
>
> The "getMetadata" method looks small enough to be inlined.
>

Ok, I'll update this one too.

Thanks,
Deng

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message