Mailing-List: contact dev-help@archiva.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@archiva.apache.org
Received-SPF: pass (nike.apache.org: domain of marecor.baclay@gmail.com
 designates 74.125.82.170 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=O+VBiYCBRY0x6RKlTsp3MuquKBabIvXZyDhkCX5F66rntTXagHV6EOFTCQz7MBjvIP
         RKaxqajxLkLbgcI2JVJtq2FxU7G3bXCb/7+1SrbFBcoQc+vREVgQSKC7TRlgDQI5oeQa
         a+WGpYPoItC2CoLZDl7iMKaoM+HRxrOOvehVo=
MIME-Version: 1.0
In-Reply-To: <8667b1bd1003181836jd32fa72v705e8cd0645959a8@mail.gmail.com>
References: <8667b1bd1003181836jd32fa72v705e8cd0645959a8@mail.gmail.com>
Date: Fri, 19 Mar 2010 10:05:52 +0800
Message-ID: <72f279c01003181905q5afac754pcac166af3951bc6d@mail.gmail.com>
Subject: Re: svn commit: r924673 - in
 /archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test:
	ArtifactManagementTest.java RepositoryTest.java
 parent/AbstractArchivaTest.java
	parent/AbstractRepositoryTest.jav
From: Marecor Baclay <marecor.baclay@gmail.com>
To: dev@archiva.apache.org
Content-Type: multipart/alternative; boundary=0016e64982a07efdb604821dc90d

--0016e64982a07efdb604821dc90d
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Mar 19, 2010 at 9:36 AM, Deng Ching <oching@apache.org> wrote:

> On Thu, Mar 18, 2010 at 5:25 PM, <mbaclay@apache.org> wrote:
>
> > Author: mbaclay
> > Date: Thu Mar 18 09:25:09 2010
> > New Revision: 924673
> >
> > URL: http://svn.apache.org/viewvc?rev=924673&view=rev
> > Log:
> > [MRM-1323] archiva webapp tests failed to run in internet explorer
> > Submitted by: Gwen Harold Autencio
> >
> >
> > Modified:
> >
> >
>  archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> >
> >
>  archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/RepositoryTest.java
> >
> >
>  archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractArchivaTest.java
> >
> >
>  archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractRepositoryTest.java
> >
> > Modified:
> >
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> > URL:
> >
> http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java?rev=924673&r1=924672&r2=924673&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> > (original)
> > +++
> >
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> > Thu Mar 18 09:25:09 2010
> > @@ -96,15 +96,15 @@ public class ArtifactManagementTest
> >     @Test( groups = "requiresUpload" )
> >     public void testDotNetTypes()
> >     {
> > -        addArtifact( getGroupId(), "testDotNetTypes", getVersion(),
> > "library", getArtifactFilePath(),
> > +        addArtifact( "dotNetTypes", "dotNetTypes", getVersion(),
> > "library", getArtifactFilePath(),
> >                      getRepositoryId() );
> > -        assertTextPresent( "Artifact 'test:testDotNetTypes:1.0' was
> > successfully deployed to repository 'internal'" );
> > -        getSelenium().open( baseUrl + "/browse/" + getGroupId() +
> > "/testDotNetTypes/" + getVersion() );
> > +        assertTextPresent( "Artifact 'dotNetTypes:dotNetTypes:1.0' was
> > successfully deployed to repository 'internal'" );
> > +        getSelenium().open( baseUrl + "/browse/" + "dotNetTypes" +
> > "/dotNetTypes/" + getVersion() );
> >         waitPage();
>
>
> >         assertTextPresent( "<type>library</type>" );
> >         String basePath =
> > -            "/archiva/repository/internal/" + getGroupId() +
> > "/testDotNetTypes/" + getVersion() + "/testDotNetTypes-" +
> > +            "/archiva/repository/internal/" + "dotNetTypes" +
> > "/dotNetTypes/" + getVersion() + "/dotNetTypes-" +
> >                 getVersion();
> >
>
> Can we add the groupId, artifactId and version for the dotnet types test to
> testng.properties instead of having it hard coded in the tests please? :)
>

Ok. Will do.. Thanks Deng! :-)


>
> Thanks,
> Deng
>

--0016e64982a07efdb604821dc90d--