archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r798827 - in /archiva/trunk/archiva-modules/archiva-web: archiva-webapp/src/main/resources/ archiva-webdav/src/main/java/org/apache/maven/archiva/webdav/
Date Wed, 29 Jul 2009 17:18:50 GMT

On 29/07/2009, at 5:55 AM, oching@apache.org wrote:

> Author: oching
> Date: Wed Jul 29 09:55:18 2009
> New Revision: 798827
>
> URL: http://svn.apache.org/viewvc?rev=798827&view=rev
> Log:
> [MRM-1163] Add some decent logs in webdav for debugging purposes
> Submitted by: Jevica Arianne Zurbano
> o added debug logs in ArchivaDavResource and  
> ArchivaDavResourceFactory with the filename, directory, repository,  
> and/or current user included in logs
>
> Modified:
>    archiva/trunk/archiva-modules/archiva-web/archiva-webapp/src/main/ 
> resources/log4j.xml
>    archiva/trunk/archiva-modules/archiva-web/archiva-webdav/src/main/ 
> java/org/apache/maven/archiva/webdav/ArchivaDavResource.java
>    archiva/trunk/archiva-modules/archiva-web/archiva-webdav/src/main/ 
> java/org/apache/maven/archiva/webdav/ArchivaDavResourceFactory.java
>
> Modified: archiva/trunk/archiva-modules/archiva-web/archiva-webapp/ 
> src/main/resources/log4j.xml
> URL: http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp/src/main/resources/log4j.xml?rev=798827&r1=798826&r2=798827&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- archiva/trunk/archiva-modules/archiva-web/archiva-webapp/src/ 
> main/resources/log4j.xml (original)
> +++ archiva/trunk/archiva-modules/archiva-web/archiva-webapp/src/ 
> main/resources/log4j.xml Wed Jul 29 09:55:18 2009
> @@ -86,6 +86,15 @@
>   </logger>
> -->
>
> +  <!-- WebDav objects -->
> +  <logger name="org.apache.maven.archiva.webdav.ArchivaDavResource">
> +    <level value="info"/>
> +  </logger>
> +
> +  <logger  
> name="org.apache.maven.archiva.webdav.ArchivaDavResourceFactory">
> +    <level value="info"/>
> +  </logger>

These are redundant with the root logger set to info.

> +
>   <!-- squelch noisy objects (for now) -->
>   <logger name="org.apache.commons">
>     <level value="warn"/>
>
> Modified: archiva/trunk/archiva-modules/archiva-web/archiva-webdav/ 
> src/main/java/org/apache/maven/archiva/webdav/ArchivaDavResource.java
> URL: http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webdav/src/main/java/org/apache/maven/archiva/webdav/ArchivaDavResource.java?rev=798827&r1=798826&r2=798827&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- archiva/trunk/archiva-modules/archiva-web/archiva-webdav/src/ 
> main/java/org/apache/maven/archiva/webdav/ArchivaDavResource.java  
> (original)
> +++ archiva/trunk/archiva-modules/archiva-web/archiva-webdav/src/ 
> main/java/org/apache/maven/archiva/webdav/ArchivaDavResource.java  
> Wed Jul 29 09:55:18 2009
> @@ -313,12 +313,16 @@
>
>             queueRepositoryTask( localFile );
>
> +            log.debug( "File '" + resource.getDisplayName() +  
> ( exists ? "' modified " : "' created ") + "(current user '" +  
> this.principal + "')" );
> +
>             triggerAuditEvent( resource, exists ?  
> AuditEvent.MODIFY_FILE : AuditEvent.CREATE_FILE );
>         }
>         else if ( !inputContext.hasStream() && isCollection() ) //  
> New directory
>         {
>             localFile.mkdir();
>
> +            log.debug( "Directory '" + resource.getDisplayName() +  
> "' (current user '" + this.principal + "')" );
> +

directory what? :)

Why do we need these two (and several others also included) when they  
are identical to the audit log?

Thanks,
Brett


Mime
View raw message