Return-Path: Delivered-To: apmail-archiva-dev-archive@www.apache.org Received: (qmail 44392 invoked from network); 8 Jul 2008 12:20:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Jul 2008 12:20:00 -0000 Received: (qmail 22061 invoked by uid 500); 8 Jul 2008 12:20:00 -0000 Delivered-To: apmail-archiva-dev-archive@archiva.apache.org Received: (qmail 22030 invoked by uid 500); 8 Jul 2008 12:20:00 -0000 Mailing-List: contact dev-help@archiva.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@archiva.apache.org Delivered-To: mailing list dev@archiva.apache.org Received: (qmail 22019 invoked by uid 99); 8 Jul 2008 12:20:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2008 05:20:00 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [210.50.76.235] (HELO mx06.syd.iprimus.net.au) (210.50.76.235) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2008 12:19:07 +0000 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsAAFT4ckg6sjD3/2dsb2JhbAAIqx8 X-IronPort-AV: E=Sophos;i="4.30,323,1212328800"; d="scan'208";a="128563099" Received: from 247.120.dsl.syd.iprimus.net.au (HELO [172.18.237.213]) ([58.178.48.247]) by smtp06.syd.iprimus.net.au with ESMTP; 08 Jul 2008 22:18:26 +1000 Message-Id: <1D314FA9-EE28-4663-B12F-48F169085CC7@apache.org> From: Brett Porter To: dev@archiva.apache.org In-Reply-To: <20080708084422.3E6B523889F7@eris.apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: Re: svn commit: r674740 - in /archiva/trunk/archiva-modules/archiva-base: archiva-consumers/archiva-lucene-consumers/ archiva-consumers/archiva-lucene-consumers/src/main/java/org/apache/maven/archiva/consumers/lucene/ archiva-consumers/archiva-lucene-consu... Date: Tue, 8 Jul 2008 22:18:25 +1000 References: <20080708084422.3E6B523889F7@eris.apache.org> X-Mailer: Apple Mail (2.926) X-Virus-Checked: Checked by ClamAV on apache.org Hi Deng, Great to see this finally added back in, thanks :D A few quick questions... On 08/07/2008, at 6:44 PM, oching@apache.org wrote: > + public IndexJavaPublicMethodsConsumer() > + { > + includes.add( "jar" ); > + includes.add( "war" ); > + includes.add( "ear" ); > + includes.add( "zip" ); > + includes.add( "tar.gz" ); > + includes.add( "tar.bz2" ); > + includes.add( "car" ); > + includes.add( "sar" ); > + includes.add( "mar" ); > + includes.add( "rar" ); > + } why zip, tar.* ? > + if( file.getAbsolutePath().endsWith( ".jar" ) || > file.getAbsolutePath().endsWith( ".war" ) || > + file.getAbsolutePath().endsWith( ".ear" ) || > file.getAbsolutePath().endsWith( ".zip" ) || > + file.getAbsolutePath().endsWith( ".tar.gz" ) || > file.getAbsolutePath().endsWith( ".tar.bz2" ) || > + file.getAbsolutePath().endsWith( ".car" ) || > file.getAbsolutePath().endsWith( ".sar" ) || > + file.getAbsolutePath().endsWith( ".mar" ) || > file.getAbsolutePath().endsWith( ".rar" ) ) Isn't this assumed from the includes? > > Added: archiva/trunk/archiva-modules/archiva-base/archiva-consumers/ > archiva-lucene-consumers/src/test/java/org/apache/maven/archiva/ > consumers/lucene/IndexJavaPublicMethodsCrossRepositorySearch.java There seem to be a few dumped exceptions in here? Cheers, Brett -- Brett Porter brett@apache.org http://blogs.exist.com/bporter/