archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r674740 - in /archiva/trunk/archiva-modules/archiva-base: archiva-consumers/archiva-lucene-consumers/ archiva-consumers/archiva-lucene-consumers/src/main/java/org/apache/maven/archiva/consumers/lucene/ archiva-consumers/archiva-lucene-consu...
Date Tue, 08 Jul 2008 12:18:25 GMT
Hi Deng,

Great to see this finally added back in, thanks :D

A few quick questions...

On 08/07/2008, at 6:44 PM, oching@apache.org wrote:

> +    public IndexJavaPublicMethodsConsumer()
> +    {
> +        includes.add( "jar" );
> +        includes.add( "war" );
> +        includes.add( "ear" );
> +        includes.add( "zip" );
> +        includes.add( "tar.gz" );
> +        includes.add( "tar.bz2" );
> +        includes.add( "car" );
> +        includes.add( "sar" );
> +        includes.add( "mar" );
> +        includes.add( "rar" );
> +    }

why zip, tar.* ?

> +            if( file.getAbsolutePath().endsWith( ".jar" ) ||  
> file.getAbsolutePath().endsWith( ".war" ) ||
> +                    file.getAbsolutePath().endsWith( ".ear" ) ||  
> file.getAbsolutePath().endsWith( ".zip" ) ||
> +                    file.getAbsolutePath().endsWith( ".tar.gz" ) ||  
> file.getAbsolutePath().endsWith( ".tar.bz2" ) ||
> +                    file.getAbsolutePath().endsWith( ".car" ) ||  
> file.getAbsolutePath().endsWith( ".sar" ) ||
> +                    file.getAbsolutePath().endsWith( ".mar" ) ||  
> file.getAbsolutePath().endsWith( ".rar" ) )

Isn't this assumed from the includes?

>
> Added: archiva/trunk/archiva-modules/archiva-base/archiva-consumers/ 
> archiva-lucene-consumers/src/test/java/org/apache/maven/archiva/ 
> consumers/lucene/IndexJavaPublicMethodsCrossRepositorySearch.java

There seem to be a few dumped exceptions in here?

Cheers,
Brett

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


Mime
View raw message