Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: archiva-dev@maven.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-Id: <21573605-9D1A-42F5-8CA3-D39E48CF95A6@apache.org>
From: Brett Porter <brett@apache.org>
To: archiva-dev@maven.apache.org
In-Reply-To: <47FC489C.7050101@erdfelt.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Subject: Re: [plexus work] archiva-checksums
Date: Fri, 11 Apr 2008 18:57:07 +1000
References: <47FC489C.7050101@erdfelt.com>

Looks good to me. I say roll it into trunk.

A couple of uncertainties:
- isn't doFinal required?
- I think it can use more tests


Here's some nitpicking that might reduce the amount of code and make  
it clearer:
- rename Hash to ChecksumAlgorithm (might as well be consistent and  
use checksum everywhere instead of alternating through Hash, Digest,  
Checksum?)
- likewise Hasher -> Checksum
- there some duplicated code in isValidChecksums and fixChecksums that  
can be factored out
- what about passing referenceFile as a final field, since every  
method uses it?
   - but if not, it'd be better if the arg order of getChecksumFile  
and createChecksum and calculateChecksum were consistent (I would go  
with File first)
- I'd rename ChecksumFile as ChecksummedFile
- parseChecksum can be private?
- the two isValidChecksum(s) methods do different things.  
isValidChecksum should be isValidChecksum(Hash hash) { return  
isValidChecksums( new Hash[] { hash } ); }. Maybe another static  
convenience method is needed for the checksum file  
checkChecksumFile( File checksumFile ).

- Brett

On 09/04/2008, at 2:39 PM, Joakim Erdfelt wrote:
> I've been taking a stab and removing some of our dependencies on  
> various plexus components.
>
> First up, plexus-digest.
>
> I've taken the varied code from many locations and come up with a  
> stand alone archiva-checksum lib/component that I hope to be able to  
> integrate into archiva/trunk.
>
> So ... uhm ... consider this a call for discussion. ;-)
>
> - Joakim

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/