Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: archiva-dev@maven.apache.org
Received-SPF: pass (athena.apache.org: domain of oching@exist.com designates
 209.85.146.176 as permitted sender)
Message-ID: <1a57a2980801102335w9155400ke653a5a14090103f@mail.gmail.com>
Date: Fri, 11 Jan 2008 15:35:00 +0800
From: "Maria Odea Ching" <oching@apache.org>
Sender: oching@exist.com
To: archiva-dev@maven.apache.org
Subject: Re: svn commit: r610758 -
 /maven/archiva/trunk/archiva-base/archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultRepositoryProxyConnectors.java
In-Reply-To: <20080110110038.C85DC1A983A@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_93_2472065.1200036900376"
References: <20080110110038.C85DC1A983A@eris.apache.org>

------=_Part_93_2472065.1200036900376
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Nicolas,

I'm getting test failures in archiva-proxy after this change, specifically
in CacheFailuresTransferTest.
Could you please update the test case to reflect these changes? :)

Thanks,
Deng


On Jan 10, 2008 7:00 PM, <nicolas@apache.org> wrote:

> Author: nicolas
> Date: Thu Jan 10 03:00:35 2008
> New Revision: 610758
>
> URL: http://svn.apache.org/viewvc?rev=610758&view=rev
> Log:
> skip when URL is in failure cache
> cache proxy failures (404) for better performances
>
> Modified:
>
>  maven/archiva/trunk/archiva-base/archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultRepositoryProxyConnectors.java
>
> Modified:
> maven/archiva/trunk/archiva-base/archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultRepositoryProxyConnectors.java
> URL:
> http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultRepositoryProxyConnectors.java?rev=610758&r1=610757&r2=610758&view=diff
>
> ==============================================================================
> ---
> maven/archiva/trunk/archiva-base/archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultRepositoryProxyConnectors.java
> (original)
> +++
> maven/archiva/trunk/archiva-base/archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultRepositoryProxyConnectors.java
> Thu Jan 10 03:00:35 2008
> @@ -524,10 +524,15 @@
>             getLogger().info( emsg );
>             return null;
>         }
> -
> +
> +               if ( urlFailureCache.hasFailedBefore( url ) )
> +               {
> +                       throw new NotFoundException( "Url has failed
> before and cache-failure is enabled on this connector" );
> +               }
> +
>         Wagon wagon = null;
>         try
> -        {
> +        {
>             RepositoryURL repoUrl = remoteRepository.getURL();
>             String protocol = repoUrl.getProtocol();
>             wagon = (Wagon) wagons.get( protocol );
> @@ -547,7 +552,10 @@
>         }
>         catch ( NotFoundException e )
>         {
> -            // Do not cache url here.
> +                       // public repositories may be slow to access, and
> many request will fail when
> +                       // muliple repositories are "merged" by archiva
> via proxies.
> +                       // so caching "not found" is usefull here to
> enhance archiva response-time
> +            urlFailureCache.cacheFailure( url );
>             throw e;
>         }
>         catch ( NotModifiedException e )
>
>
>

------=_Part_93_2472065.1200036900376--