Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: archiva-dev@maven.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v752.3)
In-Reply-To: <471BF1F0.20501@exist.com>
References: <20071021173010.BD08B1A9832@eris.apache.org>
 <74DEE571-AA04-4AFE-91DF-F68D5BC05104@apache.org> <471BF1F0.20501@exist.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <64A3099B-E2B3-49B0-99FB-AD907A489EB5@apache.org>
Content-Transfer-Encoding: 7bit
From: Brett Porter <brett@apache.org>
Subject: Re: svn commit: r586919 - in /maven/archiva/trunk:
 archiva-base/archiva-consumers/archiva-database-consumers/src/main/java/org/apache/maven/archiva/consumers/database/
 archiva-database/src/main/java/org/apache/maven/archiva/database/
 archiva-database/src/m...
Date: Mon, 22 Oct 2007 11:10:25 +1000
To: archiva-dev@maven.apache.org


On 22/10/2007, at 10:42 AM, Maria Odea Ching wrote:

> Hi Brett,
>
> I thought that if there was a problem cleaning up the repository  
> data, the delete of the repo shouldn't proceed.. or should it? :-)

That makes sense - I just wanted to check if there was anything else.

My only concern is the saveConfiguration method returning something  
other than success and the repository will still be configured but  
most of the data deleted. I'm not sure if that's possible, though :)

Anyway, this should be fine for now - if we do push these back from  
the web layer we should ensure we have some more testing around the  
exception cases.

Thanks,
Brett

>
> Thanks,
> Deng
>
> Brett Porter wrote:
>> Hi Deng,
>>
>> On 22/10/2007, at 3:30 AM, oching@apache.org wrote:
>>
>>> @@ -89,13 +105,12 @@
>>> try
>>> {
>>> Configuration configuration =  
>>> archivaConfiguration.getConfiguration();
>>> + cleanupRepositoryData( existingRepository );
>>> removeRepository( repoid, configuration );
>>> result = saveConfiguration( configuration );
>>>
>>> if ( result.equals( SUCCESS ) )
>>> {
>>> - cleanupRepositoryData( existingRepository );
>>> -
>>
>> Can you just clarify why this was moved?