Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: archiva-dev@maven.apache.org
Received-SPF: pass (athena.apache.org: domain of nicolas.deloof@gmail.com
 designates 64.233.184.231 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=L8Stus67pwLR4XD+KRdqlmM0a2LF2H2gmF0MhXyke0omc009mwEoSMgfF1raRs9ZugJSEYBnIKBABUgFg9JViQdkQ/lH8ymsUmRJtjUkAXmTI0Ra7FIq7FLD6bt8kNkT/W9mtGSdwRk1HNESDrwUMVnRl3M7WeHM+pcVDhq1TaQ=
Message-ID: <4c39e3030710100624v4e287333md02edb8f9c839d97@mail.gmail.com>
Date: Wed, 10 Oct 2007 15:24:07 +0200
From: "nicolas de loof" <nicolas.deloof@gmail.com>
To: archiva-dev@maven.apache.org
Subject: Re: [Proposal] Repository Layout Detection/Interaction Changes.
In-Reply-To: <470CA07B.5030605@erdfelt.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_12992_32857907.1192022647786"
References: <4706B3A3.5090501@apache.org>
	 <4EC61156-4AC1-4A87-8665-E3168B0E5E9A@apache.org>
	 <470B906B.2040106@erdfelt.com>
	 <4c39e3030710090825y64ddc76fyeb0b5d428ca403fb@mail.gmail.com>
	 <1E544674-B375-4F8D-A1A7-69FD2E2C249B@apache.org>
	 <4c39e3030710092220r5804796fh458cebe2a388013a@mail.gmail.com>
	 <7CBE8591-EAE6-4757-93A4-11637AEA1539@apache.org>
	 <470CA07B.5030605@erdfelt.com>

------=_Part_12992_32857907.1192022647786
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Looks good to me,

This still relies on predefined regex for known issues, but this solves many
issues with existing artifacts. Maybe the fileNameParser specialCases should
be stored in configuration insteed ofbeeing hard coded, to prevents some
unstandard artifact beeing deployed in central to create new issues.

Nico.


2007/10/10, Joakim Erdfelt <joakim@erdfelt.com>:
>
> It works! yay!
> And there was much rejoicing...
>
> nicolas,
> Check out the new RepositoryRequest object, and ManagedRepositoryContent
> structure inside of archiva-repository-layer.
>
> There's plenty of unit tests to show that they work.
>
> Its late for me, I'm going to get some sleep and expand on this (or
> reply to all of Brett's questions) when I get up.
>
> - Joakim
>
> Brett Porter wrote:
> > Joakim seems to be indicating he'll finish something already today, so
> > we should probably take a look at that and go from there.
> >
> > - Brett
> >
> > On 10/10/2007, at 7:20 AM, nicolas de loof wrote:
> >
> >> I'd suggest a "merge" of 2 options :
> >>
> >> 1 . have an exception list, used by the LegacyBidirectionalLayout to
> >> resolve
> >> those artifactIds, maybe stored in the archiva DB or in a file (I've
> >> never
> >> used jpox, so can't say if it's simple to do)
> >>
> >> 2 . add an optional ArtifactReferenceVerifier as param of
> >> toArtifactReference(path) :
> >>
> >> public interface ArtifactReferenceVerifier
> >> {
> >>     boolean isValidReference( ArtifactReference ref );
> >> }
> >>
> >> 3 . make the BidirectionalLegacyLayout build the default
> >> [artifactId:version:classifier] and check for validity. If not, build
> >> all
> >> possible combinations and test them until getting a valid one. Store
> the
> >> result in exceptions (cache).
> >>
> >> 4 . From the DavProxyServlet, pass a verifier that check for the file
> to
> >> exists in any proxied repo.
> >> In other place, pass null. The artifact used is allready in the
> >> managed repo
> >> so is allready registered as an exception if required.
> >>
> >> Using this, we can provide a default exception list for known issues
> >> from
> >> central, and also provide with fiew changes a deterministic
> >> LegacyBidirectionalLayout with auto-enhancement of the exception list.
> >>
> >> Nico.
> >>
> >>
> >>
> >>
> >> 2007/10/9, Brett Porter <brett@apache.org>:
> >>>
> >>> Hi Nicolas,
> >>>
> >>> Thanks for the summary - it sounds spot on. Just one clarification:
> >>>
> >>> On 09/10/2007, at 5:25 PM, nicolas de loof wrote:
> >>>
> >>>> Brett suggest to have a dedicated UI to maintain a set of
> >>>> exceptions. That
> >>>> would be a way to force the LegacyBidirectionalLayout to be
> >>>> deterministic.
> >>>> This option has less impact on archiva design, but requires
> >>>> - a new web UI
> >>>> - some work for the repository manager
> >>>
> >>> I actually suggested the simplest possible route here - I think if
> >>> these can be handled via a configuration file that is enough as we
> >>> shoul be able to pre-specify the vast majority of the exceptions
> >>> based on the rules for central.
> >>>
> >>> What is your opinion on the best way forward?
> >>>
> >>> Thanks,
> >>> Brett
> >>>
> >>> --
> >>> Brett Porter - brett@apache.org
> >>> Blog: http://www.devzuz.org/blogs/bporter/
> >>>
> >
> > --
> > Brett Porter - brett@apache.org
> > Blog: http://www.devzuz.org/blogs/bporter/
> >
>
>
> --
> - Joakim Erdfelt
>   joakim@erdfelt.com
>   Open Source Software (OSS) Developer
>
>

------=_Part_12992_32857907.1192022647786--